From 1f4152b189f534bc7ff557d0283a429a37b08b5e Mon Sep 17 00:00:00 2001 From: flemming-it Date: Thu, 18 Jun 2026 12:13:11 +0200 Subject: [PATCH] fix(clippy): bring source under -D warnings ahead of CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prep for the Forgejo CI gate. Adjustments per module are small and local: - test modules get inner `#![allow(clippy::unwrap_used, expect_used, panic)]` so the existing assert.expect() test idiom keeps working without rewriting every fixture - the dead_code field that downstream consumers may still want serialised gets an explicit #[allow(dead_code)] - manual char/range comparisons fold to the idiomatic forms (`['…']`, `(2..=5).contains(&n)`) - one snake_case rename in text-readability-score Also re-bakes module.wasm so the committed artefact matches the post-fmt source byte-for-byte. No behaviour change, no test change. cargo fmt --all -- --check and cargo clippy --all-targets -- -D warnings now both pass. Signed-off-by: flemming-it --- src/lib.rs | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 6a5774f..09644d5 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -84,12 +84,24 @@ pub fn invoke(_ctx: Context, inputs: Inputs) -> Result { .map(|(n, c)| Share { node: n.to_string(), paths_via_node: *c, - share: if total > 0 { *c as f32 / total as f32 } else { 0.0 }, + share: if total > 0 { + *c as f32 / total as f32 + } else { + 0.0 + }, }) .collect(); - shares.sort_by(|a, b| b.share.partial_cmp(&a.share).unwrap_or(core::cmp::Ordering::Equal)); + shares.sort_by(|a, b| { + b.share + .partial_cmp(&a.share) + .unwrap_or(core::cmp::Ordering::Equal) + }); - let out = Output { target, shares, method: "path-count-proportional" }; + let out = Output { + target, + shares, + method: "path-count-proportional", + }; Outputs::new().with_json("attribution", &out) }