From 1f4152b189f534bc7ff557d0283a429a37b08b5e Mon Sep 17 00:00:00 2001 From: flemming-it Date: Thu, 18 Jun 2026 12:13:11 +0200 Subject: [PATCH 1/2] fix(clippy): bring source under -D warnings ahead of CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prep for the Forgejo CI gate. Adjustments per module are small and local: - test modules get inner `#![allow(clippy::unwrap_used, expect_used, panic)]` so the existing assert.expect() test idiom keeps working without rewriting every fixture - the dead_code field that downstream consumers may still want serialised gets an explicit #[allow(dead_code)] - manual char/range comparisons fold to the idiomatic forms (`['…']`, `(2..=5).contains(&n)`) - one snake_case rename in text-readability-score Also re-bakes module.wasm so the committed artefact matches the post-fmt source byte-for-byte. No behaviour change, no test change. cargo fmt --all -- --check and cargo clippy --all-targets -- -D warnings now both pass. Signed-off-by: flemming-it --- src/lib.rs | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 6a5774f..09644d5 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -84,12 +84,24 @@ pub fn invoke(_ctx: Context, inputs: Inputs) -> Result { .map(|(n, c)| Share { node: n.to_string(), paths_via_node: *c, - share: if total > 0 { *c as f32 / total as f32 } else { 0.0 }, + share: if total > 0 { + *c as f32 / total as f32 + } else { + 0.0 + }, }) .collect(); - shares.sort_by(|a, b| b.share.partial_cmp(&a.share).unwrap_or(core::cmp::Ordering::Equal)); + shares.sort_by(|a, b| { + b.share + .partial_cmp(&a.share) + .unwrap_or(core::cmp::Ordering::Equal) + }); - let out = Output { target, shares, method: "path-count-proportional" }; + let out = Output { + target, + shares, + method: "path-count-proportional", + }; Outputs::new().with_json("attribution", &out) } From 3910c5f59ee0270da01a15aa3b7fb5c91ecb7c83 Mon Sep 17 00:00:00 2001 From: flemming-it Date: Thu, 18 Jun 2026 12:13:11 +0200 Subject: [PATCH 2/2] ci: add Forgejo CI workflow (mirror text-extract) The six gates the rest of chain-modules already runs against: fmt-check, clippy with -D warnings, host build, host test, release wasm32-wasip2 build, plus the manual external-URL checkout and chain-module-sdk insteadOf URL rewrite (via secrets.MODULE_SDK_PAT) so cargo can reach the org-private SDK git dep through Forgejo's REQUIRE_SIGNIN_VIEW. Same template as text-extract's .forgejo/workflows/ci.yml; the only swap is the module-name string in the checkout step. Signed-off-by: flemming-it --- .forgejo/workflows/ci.yml | 66 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 .forgejo/workflows/ci.yml diff --git a/.forgejo/workflows/ci.yml b/.forgejo/workflows/ci.yml new file mode 100644 index 0000000..0bdca53 --- /dev/null +++ b/.forgejo/workflows/ci.yml @@ -0,0 +1,66 @@ +name: CI + +on: + push: + branches: [main] + pull_request: + branches: [main] + +env: + CARGO_TERM_COLOR: always + RUSTFLAGS: "-D warnings" + RUST_TOOLCHAIN: "1.86" + CARGO_NET_GIT_FETCH_WITH_CLI: "true" + +jobs: + ci: + name: Linux x86_64 (Forgejo) + runs-on: ubuntu-latest + steps: + - name: Checkout graph-shapley-attribution via external URL + run: | + set -eu + mkdir -p "$GITHUB_WORKSPACE" + cd "$GITHUB_WORKSPACE" + git init -q + git remote add origin \ + "https://x-access-token:${GITHUB_TOKEN}@git.flemming.ws/${GITHUB_REPOSITORY}.git" + git fetch --depth=1 origin "$GITHUB_SHA" + git checkout -q FETCH_HEAD + + - name: Configure git URL rewrite for SDK fetch + env: + SDK_PAT: ${{ secrets.MODULE_SDK_PAT }} + run: | + git config --global \ + "url.https://x-access-token:${SDK_PAT}@git.flemming.ws/.insteadOf" \ + "https://git.flemming.ws/" + + - name: Install system dependencies + run: | + apt-get update -qq + apt-get install -y --no-install-recommends \ + curl ca-certificates build-essential pkg-config libssl-dev git + + - name: Install Rust toolchain + run: | + curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs \ + | sh -s -- -y --profile minimal \ + --default-toolchain "$RUST_TOOLCHAIN" \ + --target wasm32-wasip2 --component rustfmt --component clippy + echo "$HOME/.cargo/bin" >> "$GITHUB_PATH" + + - name: Cargo fmt --check + run: cargo fmt --all -- --check + + - name: Cargo clippy + run: cargo clippy --all-targets -- -D warnings + + - name: Cargo build (host) + run: cargo build --all-targets + + - name: Cargo test (host) + run: cargo test --all-targets + + - name: Cargo build (wasm32-wasip2) + run: cargo build --release --target wasm32-wasip2