From 5c5d8df0fd9f21c66ea38d14e4c6ccf0f99d8c06 Mon Sep 17 00:00:00 2001
From: flemming-it <sf@flemming.it>
Date: Thu, 18 Jun 2026 12:13:11 +0200
Subject: [PATCH] fix(clippy): bring source under -D warnings ahead of CI
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Prep for the Forgejo CI gate. Adjustments per module are small
and local:

  - test modules get inner `#![allow(clippy::unwrap_used,
    expect_used, panic)]` so the existing assert.expect()
    test idiom keeps working without rewriting every fixture
  - the dead_code field that downstream consumers may still
    want serialised gets an explicit #[allow(dead_code)]
  - manual char/range comparisons fold to the idiomatic forms
    (`['…']`, `(2..=5).contains(&n)`)
  - one snake_case rename in text-readability-score

Also re-bakes module.wasm so the committed artefact matches
the post-fmt source byte-for-byte.

No behaviour change, no test change. cargo fmt --all -- --check
and cargo clippy --all-targets -- -D warnings now both pass.

Signed-off-by: flemming-it <sf@flemming.it>
---
 module.wasm | Bin 133148 -> 133136 bytes
 src/lib.rs  |  33 +++++++++++++++++++++++----------
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/module.wasm b/module.wasm
index 12e27d3923a610b908d90675664232d52b97c16d..0905472d9cd3af4f40417f38e100323c929f68e7 100644
GIT binary patch
delta 299
zcmXYqF-yZx6oub?FG+7-nv!%XxZFe>QpC|n7xSzXF`H>t9fgORv&|p~E)vM<Pv{_I
zD2QACKzBEPKz~68U!ud|a6Znt_r1cZ!jGPWRfF=$f=%->{7k&pGrM2H(lUaw$>zg>
zz0^u%&Fu{UkF5GGKRU;lvv5Fo!4l3$sJ+n2*HMQ9gW(Tvtq%JXB%-ag8Fe(OH~9px
z-sO`MRO1I7NfNQxTJ1`j2909TU6$r5`Ts!>*7L=o8S2ILC7$xV;3-eZ@|a?wLwyDM
zm@$=JdEj=*KwFiM)YGBsn*U=>jskKH$W_c(jl~r3c~-1v1-#t{JI0u2gtpJ5@$dD|
H7fiEXwuw9a

delta 312
zcmbO*fn&}Djt%Twj5{`SaMiLfp5NTYx67P+ss#&YJ!2gU5O4N%<Ktni%5tpn+?)`^
z$T&GUSk<0IlZio*M}ftO!JLUff!Xm7bC#n(mJ(Q45Gc$D5x&3z7UohAG-n1W1MxYs
zlmsRp57uI2nfxhOOOM4-A}33ULxEY7`2q__7Y9&<f`BG7*klf%sR~?B4zmKwWUmlq
zpvJrquMie9ra#O~4onUTYzpk2ybKDQj*MA~YznN7^~DP8S&FPYjNCAeBScn-O^1QO
zaeuv+61TJ>s{)%NqXLk@#tn3tL>AB(*2#ZDtR|lhm1y=0-R>94Se`EUl7WGN7l=7n
R1sJ%1^v&(p_Apv`0{|$fLInT-

diff --git a/src/lib.rs b/src/lib.rs
index a9642c4..d816671 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -75,11 +75,10 @@ struct Paragraph {
 #[fai_module]
 pub fn invoke(_ctx: Context, inputs: Inputs) -> Result<Outputs, ModuleError> {
     let bytes = inputs.require_bytes("content")?;
-    let mime_hint_lower: Option<String> =
-        inputs.get("mime").and_then(|p| match p {
-            Payload::Text(s) => Some(s.to_ascii_lowercase()),
-            _ => None,
-        });
+    let mime_hint_lower: Option<String> = inputs.get("mime").and_then(|p| match p {
+        Payload::Text(s) => Some(s.to_ascii_lowercase()),
+        _ => None,
+    });
 
     let mime = mime_hint_lower
         .or_else(|| sniff_mime(&bytes.data))
@@ -206,7 +205,10 @@ fn split_paragraphs(text: &str) -> Vec<Paragraph> {
         return Vec::new();
     }
     let mut out: Vec<Paragraph> = Vec::new();
-    let mut current = Paragraph { number: String::new(), text: String::new() };
+    let mut current = Paragraph {
+        number: String::new(),
+        text: String::new(),
+    };
     for line in text.lines() {
         let line = line.trim();
         if line.is_empty() {
@@ -216,7 +218,10 @@ fn split_paragraphs(text: &str) -> Vec<Paragraph> {
             if !current.text.is_empty() {
                 out.push(core::mem::replace(
                     &mut current,
-                    Paragraph { number: String::new(), text: String::new() },
+                    Paragraph {
+                        number: String::new(),
+                        text: String::new(),
+                    },
                 ));
             }
             current.number = num.to_string();
@@ -242,7 +247,7 @@ fn leading_paragraph_marker(line: &str) -> Option<&str> {
         return None;
     }
     let close = bytes.iter().position(|&b| b == b')')?;
-    if close < 2 || close > 5 {
+    if !(2..=5).contains(&close) {
         return None;
     }
     let inner = line.get(1..close)?;
@@ -299,6 +304,7 @@ fn xml_err<E: core::fmt::Display>(e: E) -> ModuleError {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::unwrap_used, clippy::expect_used, clippy::panic)]
     use super::*;
 
     const SAMPLE_GEWO_14: &str = r#"<?xml version="1.0" encoding="UTF-8"?>
@@ -332,7 +338,11 @@ mod tests {
         let norm = normalize_gii_xml(SAMPLE_GEWO_14.as_bytes()).expect("parse ok");
         assert_eq!(norm.paragraphs.len(), 2);
         assert_eq!(norm.paragraphs[0].number, "(1)");
-        assert!(norm.paragraphs[0].text.starts_with("Wer den selbstständigen"));
+        assert!(
+            norm.paragraphs[0]
+                .text
+                .starts_with("Wer den selbstständigen")
+        );
         assert_eq!(norm.paragraphs[1].number, "(2)");
     }
 
@@ -351,7 +361,10 @@ mod tests {
             sniff_mime(b"<?xml version=\"1.0\"?><dokumente>"),
             Some("application/xml".into())
         );
-        assert_eq!(sniff_mime(b"<dokumente><norm/>"), Some("application/xml".into()));
+        assert_eq!(
+            sniff_mime(b"<dokumente><norm/>"),
+            Some("application/xml".into())
+        );
         assert_eq!(sniff_mime(b"%PDF-1.4 ..."), None);
     }
 }