fix: come back quickly after a hub restart, and pin the dependencies
Two things helloeco ran into while wiring the gateway. grpc-js waits a second before its second reconnect attempt and backs off towards two minutes. That is right for a far-away service and wrong for a hub on the same network: after a restart or a deploy a gateway sits out the backoff with requests in hand. The client now sets initial 200 ms and a 5 s ceiling, and a caller's own channelOptions still win. The client exposes the options it ended up with, which is the only way to tell a default that applies from one that was silently replaced. The dependencies are pinned exactly instead of by range. This package is consumed by a handful of services, not by a library ecosystem, and a surprise minor of grpc-js is what breaks a portal at three in the morning. Raising one is a commit, with the skew job in front of it. Guards: the defaults and the precedence are asserted (probed by mutation), plus a case that a run works again once the hub is back. Signed-off-by: flemming-it <sf@flemming.it>
This commit is contained in:
parent
986377f1df
commit
2131193f1f
4 changed files with 86 additions and 6 deletions
18
README.md
18
README.md
|
|
@ -115,6 +115,24 @@ memory and is lost, while approvals live in SQLite and survive. A
|
|||
gateway has to treat "approval still pending after a restart" as a run
|
||||
it must start again.
|
||||
|
||||
## Versions and the channel
|
||||
|
||||
The dependencies are pinned exactly, not by range. This package is
|
||||
consumed by a handful of services rather than by a library
|
||||
ecosystem, and a surprise minor of grpc-js is the kind of thing that
|
||||
breaks a portal at three in the morning. Raising one is a commit, and
|
||||
the skew job runs against a released hub before it lands.
|
||||
|
||||
The client sets two channel options by default:
|
||||
`grpc.initial_reconnect_backoff_ms: 200` and
|
||||
`grpc.max_reconnect_backoff_ms: 5000`. grpc-js otherwise waits a
|
||||
second before its second reconnect attempt and backs off towards two
|
||||
minutes, which is right for a far-away service and wrong for a hub on
|
||||
the same network: after a restart or a deploy, a gateway would sit
|
||||
out that backoff with requests in hand. Anything in
|
||||
`channelOptions` wins over these, and `client.channelOptions` says
|
||||
what the client ended up with.
|
||||
|
||||
## Development
|
||||
|
||||
```bash
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue