feat(test): hermetic hub fake + state-matrix sweep across all pages
The widget suites used to talk to whatever listens on the real endpoint — results depended on the operator's machine (a running hub fed real data into a11y/responsive runs and its gRPC channel timers caused the historic flake). Hardening round: - HubService.instance is now injectable (debugSetInstance); FakeHubService (test/support/fake_hub.dart) answers every member the pages touch with healthy-empty defaults and scripts per-RPC failures (UNIMPLEMENTED / UNAVAILABLE / detached gate) through a GrpcError-shaped fake. Unimplemented members are recorded and fail the sweep with the exact list. - state_matrix_test.dart pins the app-wide invariants for every sidebar page x hub condition: healthy => no unreachable claims and no raw error text; hub gone => honest unreachable states; UNIMPLEMENTED => never 'not reachable' while the sidebar shows connected; detached gate => plain-language feature-off state. - a11y + responsive sweeps now inject the fake (hermetic); the 6-minute idle-timer drain workaround is gone with the cause. Real bugs the new sweep caught immediately: - every data page (store, doctor, audit, approvals, federation) folded ANY load failure into 'hub not reachable' — the runs-page bug class; they now share HubLoadErrorView, which classifies into unreachable / needs-newer-hub / load-failed-with-copyable- detail (new generic DE+EN strings) - the approvals page's hidden tab had no future listener: a load failure there surfaced as an uncaught async error - the audit status bar rendered the raw gRPC error wall verbatim; it now shows the classified friendly headline (still selectable) Signed-off-by: flemming-it <stefan.a.flemming@googlemail.com>
This commit is contained in:
flemming-it
parent
adc5fc2311
commit
66b26304fd
19 changed files with 733 additions and 97 deletions
|
|
@ -89,6 +89,12 @@ class _ApprovalsPageState extends State<ApprovalsPage>
|
|||
limit: 200,
|
||||
project: project,
|
||||
);
|
||||
// Only the visible tab has a FutureBuilder listening; give the
|
||||
// hidden tab's future a silent listener so a load failure there
|
||||
// never surfaces as an uncaught async error (the FutureBuilder
|
||||
// that attaches on tab switch still receives the error).
|
||||
_pendingFuture.then((_) {}, onError: (_) {});
|
||||
_historyFuture.then((_) {}, onError: (_) {});
|
||||
});
|
||||
}
|
||||
|
||||
|
|
@ -331,7 +337,6 @@ class _PendingList extends StatelessWidget {
|
|||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final theme = Theme.of(context);
|
||||
final l = AppLocalizations.of(context)!;
|
||||
return FutureBuilder<List<ApprovalRecord>>(
|
||||
future: future,
|
||||
|
|
@ -340,16 +345,7 @@ class _PendingList extends StatelessWidget {
|
|||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
if (snapshot.hasError) {
|
||||
return ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: theme.colorScheme.error,
|
||||
title: l.hubUnreachable,
|
||||
hint: l.hubUnreachableHint,
|
||||
action: FilledButton.tonal(
|
||||
onPressed: onRetry,
|
||||
child: Text(l.buttonRetry),
|
||||
),
|
||||
);
|
||||
return HubLoadErrorView(error: snapshot.error!, onRetry: onRetry);
|
||||
}
|
||||
final pending = snapshot.data ?? [];
|
||||
if (pending.isEmpty) {
|
||||
|
|
@ -513,7 +509,6 @@ class _HistoryList extends StatelessWidget {
|
|||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final theme = Theme.of(context);
|
||||
final l = AppLocalizations.of(context)!;
|
||||
return FutureBuilder<List<ApprovalRecord>>(
|
||||
future: future,
|
||||
|
|
@ -522,16 +517,7 @@ class _HistoryList extends StatelessWidget {
|
|||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
if (snapshot.hasError) {
|
||||
return ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: theme.colorScheme.error,
|
||||
title: l.hubUnreachable,
|
||||
hint: l.hubUnreachableHint,
|
||||
action: FilledButton.tonal(
|
||||
onPressed: onRetry,
|
||||
child: Text(l.buttonRetry),
|
||||
),
|
||||
);
|
||||
return HubLoadErrorView(error: snapshot.error!, onRetry: onRetry);
|
||||
}
|
||||
final decided = snapshot.data ?? [];
|
||||
if (decided.isEmpty) {
|
||||
|
|
|
|||
|
|
@ -6,6 +6,7 @@ import 'package:file_picker/file_picker.dart';
|
|||
import 'package:flutter/material.dart';
|
||||
|
||||
import '../data/error_presentation.dart';
|
||||
import '../data/friendly_error.dart';
|
||||
import '../data/hub.dart';
|
||||
import '../data/workspace.dart';
|
||||
import '../l10n/app_localizations.dart';
|
||||
|
|
@ -69,7 +70,7 @@ class _AuditPageState extends State<AuditPage> {
|
|||
String _typeFilter = 'all';
|
||||
String _search = '';
|
||||
List<AuditEvent> _events = const [];
|
||||
String? _error;
|
||||
Object? _error;
|
||||
bool _initialLoaded = false;
|
||||
Timer? _poller;
|
||||
|
||||
|
|
@ -274,7 +275,7 @@ class _AuditPageState extends State<AuditPage> {
|
|||
} catch (e) {
|
||||
if (!mounted) return;
|
||||
setState(() {
|
||||
_error = e.toString();
|
||||
_error = e;
|
||||
_initialLoaded = true;
|
||||
});
|
||||
}
|
||||
|
|
@ -363,7 +364,18 @@ class _AuditPageState extends State<AuditPage> {
|
|||
),
|
||||
body: Column(
|
||||
children: [
|
||||
_LiveStatusBar(eventCount: filtered.length, error: _error),
|
||||
// The status bar shows the CLASSIFIED one-liner, never the
|
||||
// raw thrown object — walls of gRPC text belong behind the
|
||||
// error state's detail expander (state-matrix invariant).
|
||||
_LiveStatusBar(
|
||||
eventCount: filtered.length,
|
||||
error: _error == null
|
||||
? null
|
||||
: friendlyError(
|
||||
_error!,
|
||||
AppLocalizations.of(context)!,
|
||||
).headline,
|
||||
),
|
||||
Padding(
|
||||
padding: const EdgeInsets.fromLTRB(
|
||||
ChainSpace.xl,
|
||||
|
|
@ -388,12 +400,7 @@ class _AuditPageState extends State<AuditPage> {
|
|||
child: !_initialLoaded
|
||||
? const Center(child: CircularProgressIndicator())
|
||||
: _error != null && _events.isEmpty
|
||||
? ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: theme.colorScheme.error,
|
||||
title: AppLocalizations.of(context)!.hubUnreachable,
|
||||
hint: AppLocalizations.of(context)!.hubUnreachableHint,
|
||||
)
|
||||
? HubLoadErrorView(error: _error!, onRetry: _refresh)
|
||||
: filtered.isEmpty
|
||||
? ChainEmptyState(
|
||||
icon: Icons.timeline_outlined,
|
||||
|
|
|
|||
|
|
@ -60,17 +60,7 @@ class _DoctorPageState extends State<DoctorPage> {
|
|||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
if (snapshot.hasError) {
|
||||
final l = AppLocalizations.of(context)!;
|
||||
return ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: Theme.of(context).colorScheme.error,
|
||||
title: l.hubUnreachable,
|
||||
hint: l.hubUnreachableHint,
|
||||
action: FilledButton.tonal(
|
||||
onPressed: _refresh,
|
||||
child: Text(l.buttonRetry),
|
||||
),
|
||||
);
|
||||
return HubLoadErrorView(error: snapshot.error!, onRetry: _refresh);
|
||||
}
|
||||
final s = snapshot.data!;
|
||||
final showUpdate =
|
||||
|
|
|
|||
|
|
@ -126,16 +126,7 @@ class _FederationPageState extends State<FederationPage> {
|
|||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
if (snapshot.hasError) {
|
||||
return ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: theme.colorScheme.error,
|
||||
title: l.hubUnreachable,
|
||||
hint: l.hubUnreachableHint,
|
||||
action: FilledButton.tonal(
|
||||
onPressed: _refresh,
|
||||
child: Text(l.buttonRetry),
|
||||
),
|
||||
);
|
||||
return HubLoadErrorView(error: snapshot.error!, onRetry: _refresh);
|
||||
}
|
||||
final sats = snapshot.data ?? [];
|
||||
if (sats.isEmpty) {
|
||||
|
|
|
|||
|
|
@ -51,30 +51,22 @@ enum RunsLoadIssue {
|
|||
}
|
||||
|
||||
/// Classify a [HubService.listDetachedRuns] failure into the view
|
||||
/// state the page should render.
|
||||
/// state the page should render. The runs-specific part is the
|
||||
/// detached feature gate; everything else delegates to the shared
|
||||
/// page-load classification.
|
||||
RunsLoadIssue classifyRunsLoadError(Object error) {
|
||||
switch (grpcCodeOf(error)) {
|
||||
case 12: // UNIMPLEMENTED — hub predates the RPC
|
||||
return RunsLoadIssue.unsupported;
|
||||
case 9: // FAILED_PRECONDITION — the hub's detached gate
|
||||
final msg = (grpcMessageOf(error) ?? '').toLowerCase();
|
||||
return msg.contains('detached')
|
||||
? RunsLoadIssue.featureDisabled
|
||||
: RunsLoadIssue.other;
|
||||
case 4: // DEADLINE_EXCEEDED
|
||||
case 14: // UNAVAILABLE
|
||||
return RunsLoadIssue.unreachable;
|
||||
if (grpcCodeOf(error) == 9) {
|
||||
// FAILED_PRECONDITION — the hub's detached gate.
|
||||
final msg = (grpcMessageOf(error) ?? '').toLowerCase();
|
||||
return msg.contains('detached')
|
||||
? RunsLoadIssue.featureDisabled
|
||||
: RunsLoadIssue.other;
|
||||
}
|
||||
// Non-gRPC failures: only clear socket-level shapes count as
|
||||
// "unreachable"; everything else keeps its real story.
|
||||
final s = error.toString().toLowerCase();
|
||||
if (s.contains('socketexception') ||
|
||||
s.contains('connection refused') ||
|
||||
s.contains('connection terminated') ||
|
||||
s.contains('failed to connect')) {
|
||||
return RunsLoadIssue.unreachable;
|
||||
}
|
||||
return RunsLoadIssue.other;
|
||||
return switch (classifyHubLoadError(error)) {
|
||||
HubLoadIssue.unreachable => RunsLoadIssue.unreachable,
|
||||
HubLoadIssue.unsupported => RunsLoadIssue.unsupported,
|
||||
HubLoadIssue.other => RunsLoadIssue.other,
|
||||
};
|
||||
}
|
||||
|
||||
/// The error rendition of the runs monitor — public + callback-driven
|
||||
|
|
|
|||
|
|
@ -288,15 +288,9 @@ class _StorePageState extends State<StorePage> {
|
|||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
if (snap.hasError) {
|
||||
return ChainEmptyState(
|
||||
icon: Icons.cloud_off_outlined,
|
||||
iconColor: theme.colorScheme.error,
|
||||
title: l.hubUnreachable,
|
||||
hint: l.hubUnreachableHint,
|
||||
action: FilledButton.tonal(
|
||||
onPressed: _runSearch,
|
||||
child: Text(l.buttonRetry),
|
||||
),
|
||||
return HubLoadErrorView(
|
||||
error: snap.error!,
|
||||
onRetry: _runSearch,
|
||||
);
|
||||
}
|
||||
final raw = snap.data ?? const <StoreItem>[];
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue