feat(studio): trust pass — friendly errors + store clarity + MCP i18n
Second half of the May-2026 trust pass. Drops the wall of gRPC trailers from every error surface and makes the Store honest about what is and isn't installable. Friendly errors: - New `friendlyError(Object, AppLocalizations)` mapper turns GrpcError + arbitrary throwables into a localised headline, optional recovery hint, and a verbatim detail string kept behind a "Show details" expander. Duck-typed on `.code` / `.message` so Studio doesn't have to depend on package:grpc directly. - `FaiErrorBox` gains an `error:` constructor that runs the mapper. Every call site that used to render `snap.error.toString()` (flows, welcome, store) switches to it. - 9 .arb entries per locale cover the gRPC codes we actually emit (INVALID_ARGUMENT, NOT_FOUND, ALREADY_EXISTS, PERMISSION_DENIED, FAILED_PRECONDITION, INTERNAL, UNAVAILABLE, UNAUTHENTICATED) plus copy/details affordances. - `test/friendly_error_test.dart` — 6 unit tests for the mapper. Covers the mapping table, locale-switching, and the non-gRPC fallback so future regressions show up in CI. Capability discovery: - New `HubService.allCapabilities()` reads the kind-aware capability list (wasm + builtin + federated) and returns a Dart-side `CapabilityInfo` value type. The flow page's missing-dependency check uses it so `system.approval` and federated MCP/n8n tools count as "available" — fixes the Run button staying disabled forever. - `HubService.listModules()` filters to kind=wasm so the Modules page doesn't sprout synthetic "system" entries that the operator can't uninstall. Store clarity: - New "Installable only" filter, on by default. Roughly 2/3 of seed entries currently carry `status: planned`; the default view stops being noise. - Featured-strip cards for planned modules now show a "Coming soon" pill instead of an empty action area. - Main-grid cards for non-installable modules dim to 60% opacity so the eye lands on actionable cards first. - Detail-sheet "Nicht installierbar" tooltip → inline hint box. The reason is visible without hovering. MCP localisation: - `_kMcpSuggestions` no longer holds 11 hardcoded English description strings. The `description` field is replaced with a `resolveDescription(AppLocalizations)` lookup that switches on the suggestion `name` to read the matching `mcpSuggestion*Desc` .arb key. EN + DE shipped. - New `FaiEnBadge` widget renders a small `[EN]` pill when the active locale isn't English. Used next to MCP / federated store entries' tagline + description because the server supplies them in English and we can't translate on the fly yet — the badge is the honest signal until the planned `studio.translate` plugin lands. Plus housekeeping: removed the unused `_keepImport` lint escape in the test and the dangling library doc-comment in `format.dart`. Signed-off-by: flemming-it <sf@flemming.it> Signed-off-by: flemming-it <stefan.a.flemming@googlemail.com>
This commit is contained in:
flemming-it
parent
34f2b7b313
commit
c11461b0f9
15 changed files with 1219 additions and 104 deletions
|
|
@ -29,30 +29,27 @@ class _FlowsPageState extends State<FlowsPage> {
|
|||
_future = _load();
|
||||
}
|
||||
|
||||
/// Pulls the saved flows AND the installed-modules list in
|
||||
/// parallel so the page can compute "is this flow runnable"
|
||||
/// per row from the same data the Run button gates on.
|
||||
/// Pulls the saved flows AND every capability the hub can
|
||||
/// execute (WASM modules + built-ins like `system.approval` +
|
||||
/// federated MCP/n8n tools) in parallel so the page can
|
||||
/// compute "is this flow runnable" per row.
|
||||
///
|
||||
/// Using `allCapabilities()` instead of `listModules()` is
|
||||
/// load-bearing: built-ins are not WASM modules, so they would
|
||||
/// never appear in a module-grouped list — and a flow that
|
||||
/// uses `system.approval@^0` would stay stuck on "missing
|
||||
/// dependency" forever.
|
||||
Future<_FlowsBundle> _load() async {
|
||||
final results = await Future.wait([
|
||||
HubService.instance.listFlows(),
|
||||
HubService.instance.listModules().catchError((_) => <ModuleSummary>[]),
|
||||
HubService.instance
|
||||
.allCapabilities()
|
||||
.catchError((_) => <CapabilityInfo>[]),
|
||||
]);
|
||||
return _FlowsBundle(
|
||||
flows: results[0] as List<SavedFlow>,
|
||||
installedCapabilities: (results[1] as List<ModuleSummary>)
|
||||
.expand((m) => m.capabilities)
|
||||
// `listModules()` emits capability strings with a
|
||||
// `@version` suffix (e.g. `text.extract@0.1.0`). The
|
||||
// flow's `requiredCapabilities` carry their own
|
||||
// user-typed version constraint, so we compare on the
|
||||
// bare capability name and let the hub do the strict
|
||||
// version match at run time. Without this strip, the
|
||||
// contains-check would never hit and the Run button
|
||||
// would stay disabled even after a successful install.
|
||||
.map((c) {
|
||||
final at = c.indexOf('@');
|
||||
return at >= 0 ? c.substring(0, at) : c;
|
||||
})
|
||||
installedCapabilities: (results[1] as List<CapabilityInfo>)
|
||||
.map((c) => c.capability)
|
||||
.toSet(),
|
||||
);
|
||||
}
|
||||
|
|
@ -638,7 +635,7 @@ class _FlowInputDialogState extends State<_FlowInputDialog> {
|
|||
),
|
||||
const SizedBox(height: FaiSpace.sm),
|
||||
FaiErrorBox(
|
||||
text: snap.error.toString(),
|
||||
error: snap.error,
|
||||
isError: true,
|
||||
maxHeight: 200,
|
||||
),
|
||||
|
|
@ -887,7 +884,7 @@ class _FlowRunDialogState extends State<_FlowRunDialog> {
|
|||
),
|
||||
const SizedBox(height: FaiSpace.md),
|
||||
FaiErrorBox(
|
||||
text: snapshot.error.toString(),
|
||||
error: snapshot.error,
|
||||
isError: true,
|
||||
maxHeight: 280,
|
||||
),
|
||||
|
|
@ -957,7 +954,10 @@ class _InstallItemState {
|
|||
|
||||
_InstallStatus status;
|
||||
String? installedVersion;
|
||||
String? error;
|
||||
/// Original thrown object so the UI can run it through
|
||||
/// [friendlyError] later instead of staring at a wall of gRPC
|
||||
/// trailers.
|
||||
Object? error;
|
||||
|
||||
_InstallItemState(this.spec)
|
||||
: bareName = _stripVersion(spec),
|
||||
|
|
@ -1015,7 +1015,7 @@ class _InstallDependenciesDialogState
|
|||
if (!mounted) return;
|
||||
setState(() {
|
||||
item.status = _InstallStatus.failed;
|
||||
item.error = e.toString();
|
||||
item.error = e;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
|
@ -1042,8 +1042,9 @@ class _InstallDependenciesDialogState
|
|||
i.status == _InstallStatus.failed && _isAuthWallError(i.error),
|
||||
);
|
||||
|
||||
static bool _isAuthWallError(String? msg) {
|
||||
if (msg == null) return false;
|
||||
static bool _isAuthWallError(Object? err) {
|
||||
if (err == null) return false;
|
||||
final msg = err.toString();
|
||||
return msg.contains('registry returned an HTML page') ||
|
||||
msg.contains('no registry token configured');
|
||||
}
|
||||
|
|
@ -1163,7 +1164,7 @@ class _InstallRow extends StatelessWidget {
|
|||
item.error != null) ...[
|
||||
const SizedBox(height: FaiSpace.xs),
|
||||
FaiErrorBox(
|
||||
text: item.error!,
|
||||
error: item.error,
|
||||
isError: true,
|
||||
maxHeight: 120,
|
||||
),
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue