fix(runs): stop claiming the hub is unreachable on RPC-level errors
The runs monitor folded every load failure into 'hub not reachable', contradicting the sidebar's green connected dot whenever the hub answered but the RPC failed — most visibly against a pre-0.22 hub whose version predates the ListInvocations RPC (UNIMPLEMENTED). Classify the failure instead (top-level, unit-tested): - UNIMPLEMENTED -> 'this view needs a newer hub version' with a doctor-page link (the update banner lives there) - FAILED_PRECONDITION from the detached gate -> the regular feature-off empty state with the guide button - UNAVAILABLE / DEADLINE_EXCEEDED / socket-level failures -> the honest 'hub not reachable' state (unchanged) - everything else -> a load-failed state with the friendly error and a copyable detail box The error view is a public callback-driven widget so the tests pump each variant without a live hub. New DE+EN strings for the too-old and load-failed states; grpcCodeOf/grpcMessageOf exposed from the friendly-error mapper instead of duplicating the duck-typing. Signed-off-by: flemming-it <stefan.a.flemming@googlemail.com>
This commit is contained in:
parent
b47d8c4646
commit
ea2cd87b5e
8 changed files with 380 additions and 7 deletions
|
|
@ -5401,6 +5401,30 @@ abstract class AppLocalizations {
|
|||
/// **'Open the guide'**
|
||||
String get runsEmptyGuideButton;
|
||||
|
||||
/// No description provided for @runsHubTooOldTitle.
|
||||
///
|
||||
/// In en, this message translates to:
|
||||
/// **'This view needs a newer hub version'**
|
||||
String get runsHubTooOldTitle;
|
||||
|
||||
/// No description provided for @runsHubTooOldHint.
|
||||
///
|
||||
/// In en, this message translates to:
|
||||
/// **'The hub is connected, but its version does not know the runs monitor yet. Update the hub and the runs will appear here.'**
|
||||
String get runsHubTooOldHint;
|
||||
|
||||
/// No description provided for @runsHubTooOldButton.
|
||||
///
|
||||
/// In en, this message translates to:
|
||||
/// **'Open Doctor'**
|
||||
String get runsHubTooOldButton;
|
||||
|
||||
/// No description provided for @runsLoadFailedTitle.
|
||||
///
|
||||
/// In en, this message translates to:
|
||||
/// **'Runs could not be loaded'**
|
||||
String get runsLoadFailedTitle;
|
||||
|
||||
/// No description provided for @runsCancelButton.
|
||||
///
|
||||
/// In en, this message translates to:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue