fix(approvals): usertest-panel hardening (0.81.0)
Panel findings against the reworked approvals page, fixed in place: - Never fabricate the request time: ApprovalRecord.createdAt is nullable now; a missing created_at omits the line instead of rendering DateTime.now() (which drifted on refresh). Guard: approvals_origin_test pins the omit-on-null invariant. - Copyable errors on approve/reject/batch via showChainErrorSnack (the hard project rule) — batch surfaces the first real cause. - Reject requires a reason: ChainInlineHelp strip + confirm disabled while empty, no more silent close-and-nothing-happens. - Batch approve applies the same no-data confirmation as the single path, naming how many selected requests carry no show: data. - Plainer language: glossary "Vorgang (Flow)", history label FRAGE (was PROMPT), no-data hint drops developer jargon. - One-click copy of the run id; history payload pretty-prints like the card. Signed-off-by: flemming-it <stefan.a.flemming@googlemail.com>
This commit is contained in:
parent
28f6fe1a9a
commit
f7d7427d91
9 changed files with 411 additions and 122 deletions
|
|
@ -1113,13 +1113,20 @@
|
|||
"approvalsPillRejected": "rejected",
|
||||
"approvalsPillExpired": "expired",
|
||||
"approvalsPayloadPreview": "DATA TO REVIEW",
|
||||
"approvalsNoPayload": "No data was attached for review. The flow's approval step chooses what to show via its \"show:\" field — set it to surface the data behind this decision.",
|
||||
"approvalsNoPayload": "No data was attached to this approval. You are deciding without a detail view — when in doubt, ask whoever set up the process. (Technical: the approval step's \"show:\" field controls what appears here.)",
|
||||
"approvalsNoDataConfirmTitle": "Approve without review data?",
|
||||
"approvalsNoDataConfirmBody": "This flow deliberately attached no review data (no \"show:\" on its approval step). You can still approve — but you would be deciding without seeing the data behind this decision.",
|
||||
"approvalsNoDataConfirmAction": "Approve anyway",
|
||||
"approvalsRequestFallback": "Approval required for this step",
|
||||
"approvalsFlowStepMeta": "Flow: {flow} · Step: {step}",
|
||||
"approvalsIntroHelp": "Paused flows waiting for your decision. Each card shows which flow is holding at which step and what data it puts in front of you — Approve resumes the flow, Reject stops it with your reason.",
|
||||
"approvalsIntroHelp": "Paused processes (flows) waiting for your decision. Each card shows which process is holding at which step and what data it puts in front of you — Approve resumes it, Reject stops it with your reason.",
|
||||
"approvalsRejectDialogHelp": "Rejecting stops the process at this step and is recorded with your reason in the audit trail.",
|
||||
"approvalsRejectReasonHelper": "Required — recorded in the audit log.",
|
||||
"approvalsBatchNoDataTitle": "Approve without review data?",
|
||||
"approvalsBatchNoDataBody": "{count, plural, =1{1 of {total} selected approvals has no review data. You are approving it without a detail view.} other{{count} of {total} selected approvals have no review data. You are approving them without a detail view.}}",
|
||||
"approvalsCopyRun": "Copy run id",
|
||||
"approvalsRunCopied": "Run id copied",
|
||||
"approvalsUnknownReviewer": "(unknown)",
|
||||
"approvalsOriginLabel": "ORIGIN",
|
||||
"approvalsOriginProject": "Project",
|
||||
"approvalsOriginRequested": "Requested",
|
||||
|
|
@ -1135,7 +1142,7 @@
|
|||
"approvalsApproveButton": "Approve",
|
||||
"approvalsRejectButton": "Reject",
|
||||
"approvalsRejectDialogTitle": "Reject approval",
|
||||
"approvalsRejectReasonLabel": "Reason (recorded in audit log)",
|
||||
"approvalsRejectReasonLabel": "Reason",
|
||||
"approvalsApprovedToast": "approved · {flow} › {step}",
|
||||
"@approvalsApprovedToast": {
|
||||
"placeholders": {
|
||||
|
|
@ -1179,7 +1186,7 @@
|
|||
"approvalsDialogDecided": "decided",
|
||||
"approvalsDialogCreated": "created",
|
||||
"approvalsDialogReason": "reason",
|
||||
"approvalsDialogPrompt": "PROMPT",
|
||||
"approvalsDialogPrompt": "QUESTION",
|
||||
"approvalsExpiresIn": "{minutes}m",
|
||||
"@approvalsExpiresIn": {
|
||||
"placeholders": {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue